chore(telemetry): add device ID resolution COMPASS-8443 #1034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
changed the title
addaleax
approved these changes
May 2, 2025
src/telemetry/telemetryService.ts
Outdated
| log.info('Segment analytics activated', this.userIdentity); | ||
|
|
||
| // Process buffered events | ||
| if (this.eventBuffer.length > 0) { |
There was a problem hiding this comment.
nit: This conditional doesn't do anything, right?
(alternatively: with these cases I definitely have a mild preference for while (event = this.eventBuffer.shift()), I know it doesn't make a real difference right now, but it's basically the same amount of syntax but provides greater resilience around potential future changes where the buffer or the isBufferingEvents flag could be changed concurrently to the loop)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds device ID to the events' user identity in the telemetry service.