CSHARP-4918: Release notes automation… #1680
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanych-sun
changed the title
sanych-sun
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR automates the generation and publication of release notes while also introducing new CI checks for pull requests.
- Updated release note processing in evergreen/release-notes.py to handle special characters and improve HTTP error handling.
- Added a new GitHub Actions workflow (.github/workflows/pr.yml) to validate PR labels, title content, and formatting.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| evergreen/release-notes.py | Updated title encoding and HTTP error handling in release notes logic. |
| .github/workflows/pr.yml | Introduced a new workflow to enforce PR label and title requirements. |
| @@ -91,7 +91,9 @@ def load_pull_requests(opts): | |||
| github_api_base_url=opts.github_api_base_url, | |||
| repo=opts.repo, | |||
| commit_sha=commit["sha"]) | |||
| pullrequests = requests.get(pullrequests_url, headers=opts.github_headers).json() | |||
| pullrequests_response = requests.get(pullrequests_url, headers=opts.github_headers) | |||
| pullrequests_response.raise_for_status() | |||
There was a problem hiding this comment.
Removing the response.raise_for_status() in publish_release_notes may mask unexpected HTTP errors; consider handling non-404 status codes explicitly to ensure accurate error reporting.
Suggested change
| pullrequests_response.raise_for_status() | |
| if pullrequests_response.status_code == 404: | |
| print(f"Warning: Pull request data not found for commit {commit['sha']} (URL: {pullrequests_url})") | |
| continue | |
| elif not pullrequests_response.ok: | |
| raise requests.HTTPError(f"HTTP error {pullrequests_response.status_code} for URL: {pullrequests_url}") |
Copilot uses AI. Check for mistakes.
sanych-sun
changed the title
sanych-sun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.