Skip to content

WIP: Remove calculate_images_to_build function #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: simon/add-calc-images-test-cases
Choose a base branch
from

Conversation

SimonBaeumer
Copy link
Member

Summary

Removing calculate_images_to_build function. This function was never used in the intended implementation. exclude was never set for pipeline.py, only include was used.
--include was only ever called once, it never used action=append. To simplify the implementation just the key of the image to build is returned.

Proof of Work

  • CI Pipline
  • rg search locally
❯ rg pipeline.py
lib/sonar/builders/docker.py
195:    # - move the logic out of sonar to pipeline.py to all the places where we build context images

inventories/daily.yaml
2:  # these variables are configured from the outside, in pipeline.py::image_config

scripts/dev/contexts/evg-private-context
98:# var used in pipeline.py to determine if we're running on EVG host

Makefile
72:	@ scripts/evergreen/run_python.sh pipeline.py --include database
75:	@ scripts/evergreen/run_python.sh pipeline.py --include readiness-probe
78:	@ scripts/evergreen/run_python.sh pipeline.py --include upgrade-hook
87:	@ scripts/evergreen/run_python.sh pipeline.py --include appdb
151:	@ scripts/evergreen/run_python.sh pipeline.py --include operator-quick
158:		scripts/evergreen/run_python.sh pipeline.py --include test; \
163:		scripts/evergreen/run_python.sh pipeline.py --include mco-test; \
178:	@ scripts/evergreen/run_python.sh pipeline.py --include init-database
181:	@ scripts/evergreen/run_python.sh pipeline.py --include init-appdb
186:	@ scripts/evergreen/run_python.sh pipeline.py --include agent --all-agents --parallel --parallel-factor 6
189:	@ scripts/evergreen/run_python.sh pipeline.py --include agent --parallel-factor 1
192:	@ scripts/evergreen/run_python.sh pipeline.py --include operator
195:	@ scripts/evergreen/run_python.sh pipeline.py --include init-ops-manager
198:	@ scripts/evergreen/run_python.sh pipeline.py --include ops-manager

scripts/dev/contexts/local-defaults-context
58:# TO ensure we don't release by accident via pipeline.py

docker/mongodb-agent/Dockerfile.builder
1:# the init database image gets supplied by pipeline.py and corresponds to the operator version we want to release

@SimonBaeumer SimonBaeumer requested a review from a team as a code owner May 15, 2025 15:55
@SimonBaeumer SimonBaeumer requested review from MaciejKaras and mircea-cosbuc and removed request for a team May 15, 2025 15:55
@SimonBaeumer SimonBaeumer changed the title Remove calculate_images_to_build function WIP: Remove calculate_images_to_build function May 15, 2025
@SimonBaeumer SimonBaeumer force-pushed the simon/add-calc-images-test-cases branch 2 times, most recently from 8c1cb60 to b333772 Compare May 16, 2025 09:34
@SimonBaeumer SimonBaeumer marked this pull request as draft May 26, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants