Skip to content

Declare equals() as final #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2016
Merged

Declare equals() as final #40

merged 4 commits into from
Oct 9, 2016

Conversation

jeremykendall
Copy link
Contributor

Addresses suggestions from conversation in #4.

  • Adds final to equals()
  • Update tests per suggestions from @mirfilip
    • Rewrite original tests
    • Add tests proving equals() handles problematic values properly
  • Add equals() to documentation

@jeremykendall jeremykendall mentioned this pull request Oct 6, 2016
Closed
@mirfilip
Copy link

mirfilip commented Oct 6, 2016

That's a solid PR 👍

@chippyash
Copy link

Good practice. Good pr.

@mnapoli
Copy link
Member

mnapoli commented Oct 9, 2016

Awesome!

@mnapoli mnapoli merged commit 9818c63 into myclabs:master Oct 9, 2016
@jeremykendall
Copy link
Contributor Author

Thanks everyone!

@jeremykendall jeremykendall deleted the feature/declare-equals-final branch October 9, 2016 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeremykendall @mirfilip @chippyash @mnapoli