Skip to content

Fixes #19444: Fix change logging for contact group assignments #19456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

jeremystretch
Copy link
Member

Fixes: #19444

  • Remove the custom ContactGroupMembership "through" model for contact group assignments
  • Introduce a crafted migration to transparently handle the database changes

@jeremystretch jeremystretch requested review from a team and bctiemann and removed request for a team May 9, 2025 18:22
@jeremystretch jeremystretch changed the title Fixes #19444: Fix changeloggin for contact group assignments Fixes #19444: Fix change logging for contact group assignments May 12, 2025
@bctiemann
Copy link
Contributor

I noticed that adding a contact to a group as well as a sub-group of that group causes the total count of contacts in the group to be +1 from what you would expect, i.e. it counts total assignments rather than distinct contacts; but that is not new behavior and is out of scope for this fix.

@bctiemann bctiemann merged commit 6b9b5c4 into main May 13, 2025
10 checks passed
@jeremystretch jeremystretch deleted the 19444-contact-groups-changelog branch May 13, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact group assignments are not recorded in changelog
2 participants