Skip to content

feat(NcPopover): document all properties and remove transparent floating-vue wrapper #6802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

feat(NcPopover): document all properties and remove transparent floating-vue wrapper #6802

merged 1 commit into from
Apr 25, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 17, 2025 •
edited
Loading

☑️ Resolves

  1. Document all properties used by Nextcloud apps (I checked for all usage in the nextcloud GitHub organization)
  2. Remove mention of the wrapped library
  3. Add feature to use logical direction in the placement prop

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews feature: popover Related to the popovermenu component 💥 breaking PR that requires a new major version labels Apr 17, 2025
@susnux susnux added this to the v9.0.0-rc.0 milestone Apr 17, 2025
@susnux susnux requested a review from ShGKme April 17, 2025 16:09
ShGKme
ShGKme reviewed Apr 17, 2025
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked only bidi part yet

@susnux susnux mentioned this pull request Apr 18, 2025
Merged
3 tasks
@susnux susnux force-pushed the feat/nc-popover branch 3 times, most recently from a626f5a to be765e6 Compare April 20, 2025 10:13
@susnux susnux removed the 💥 breaking PR that requires a new major version label Apr 20, 2025
@susnux susnux changed the title feat(NcPopover)!: document all properties and remove transparent floating-vue wrapper feat(NcPopover): document all properties and remove transparent floating-vue wrapper Apr 20, 2025
@susnux susnux mentioned this pull request Apr 22, 2025
Merged
4 tasks
@susnux susnux requested review from ShGKme, st3iny and Antreesy April 24, 2025 08:33
Antreesy
Antreesy reviewed Apr 24, 2025
View reviewed changes
@susnux
feat(NcPopover): add properties instead of linking to wrapped library
5e1c7e9 
- Also support RTL design

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit ba77a68 into main Apr 25, 2025
29 checks passed
@susnux susnux deleted the feat/nc-popover branch April 25, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy left review comments

@nfebe nfebe nfebe approved these changes

@ShGKme ShGKme ShGKme approved these changes

@st3iny st3iny Awaiting requested review from st3iny

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request feature: popover Related to the popovermenu component
Projects
None yet
Milestone
v9.0.0-rc.0
Development

Successfully merging this pull request may close these issues.

Last call for @nextcloud/vue v9 breaking changes
4 participants
@susnux @nfebe @ShGKme @Antreesy