enable default collector #1044
Merged
enable default collector #1044
+187
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigell
approved these changes
Apr 17, 2025
craigell
approved these changes
Apr 22, 2025
dhurley
reviewed
Apr 22, 2025
internal/config/config.go
Outdated
| @@ -123,6 +128,60 @@ func ResolveConfig() (*Config, error) { | |||
| return config, nil | |||
| } | |||
|
|
|||
| func checkCollectorConfiguration(collector *Collector, config *Config) { | |||
| if len(collector.Exporters.OtlpExporters) == 0 && collector.Exporters.PrometheusExporter == nil && | |||
There was a problem hiding this comment.
Could you add some functions here to make it clearer what the if statement is doing? Like IsOTelExporterConfigured()
internal/datasource/file/file.go
Outdated
| "os" | ||
| ) | ||
|
|
||
| func RetrieveTokenFromFile(path string) (string, error) { |
There was a problem hiding this comment.
Suggested change
| func RetrieveTokenFromFile(path string) (string, error) { | |
| func ReadFile(path string) (string, error) { |
Can the name for this function be more generic? It could be reused in the future to read other things from files.
internal/datasource/file/file.go
Outdated
|
|
||
| func RetrieveTokenFromFile(path string) (string, error) { | ||
| if path == "" { | ||
| return "", errors.New("token file path is empty") |
There was a problem hiding this comment.
Suggested change
| return "", errors.New("token file path is empty") | |
| return "", errors.New("failed to read file since file path is empty") |
NutsaB
approved these changes
Apr 22, 2025
dhurley
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
If valid command server block is configured in the nginx-agent.conf but no processors are found in the collector block, a collector will be created using defaults.
Default Collector Settings
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)