Skip to content

Fix setting ScaleDefined in SqlType #3524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

gliljas
Copy link
Member

@gliljas gliljas commented Apr 8, 2024

Fixes #3523

@hazzik
Copy link
Member

hazzik commented Apr 10, 2024

I personally hate the concept of xxxDefined. This is old pre-nullable way of doing things and I think it should be done by Nullable<X> now instead:

private int? length;
public int Length => length.GetValueOrDefault();
public bool LengthDefined => length.HasValue;

@gliljas
Copy link
Member Author

gliljas commented Apr 10, 2024

I personally hate the concept of xxxDefined. This is old pre-nullable way of doing things and I think it should be done by Nullable<X> now instead:

private int? length;
public int Length => length.GetValueOrDefault();
public bool LengthDefined => length.HasValue;

Done

@hazzik hazzik added this to the 5.6 milestone Apr 11, 2024
@hazzik hazzik changed the title Set ScaleDefined in SqlType. Remove use of explicit backing fields. Fix setting ScaleDefined in SqlType Apr 11, 2024
@hazzik hazzik enabled auto-merge (squash) April 12, 2024 10:20
@hazzik hazzik merged commit 07c0502 into nhibernate:master Apr 12, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScaleDefined is not set by SqlType ctor
3 participants