-
Notifications
You must be signed in to change notification settings - Fork 934
Treat all non-virtual methods of System.Object as not proxiable #3538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/NHibernate.Test/NHSpecificTest/ProxyValidator/ShouldBeProxiableTests.cs
Show resolved
Hide resolved
In theory we could mark all |
@fredericDelaporte, I have a question. Should I re-target the changes to an earlier version? If so what? (I think we need a support policy so it would be clearer in the future). |
Since we usually take long for releasing the next minor version, yes, you are right, we should target a lower version. The currently released minor seems enough to me. I would rather not target older versions. That is more work which gives an incentive for not upgrading to the latest minor, which I do not see as desirable. It is reasonable to let older versions be broken by .net versions which were not released when the older version was the latest. |
Ok, cool. I'll squash and re-target to 5.5.x branch then. |
Fixes #3536