bugfix: Setting OMPI_MPI_THREAD_LEVEL to a value different than requested crashes #13211
+23
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abouteiller
commented
Apr 25, 2025
abouteiller
force-pushed
the
bugfix/env-thread-level-ignored
branch
4 times, most recently
from
b71461f to
b481893
Compare
jsquyres
reviewed
May 5, 2025
| @@ -46,7 +47,8 @@ PROTOTYPE INT init(INT_OUT argc, ARGV argv) | |||
|
|
|||
| if (NULL != (env = getenv("OMPI_MPI_THREAD_LEVEL"))) { | |||
| required = atoi(env); | |||
| if (required < MPI_THREAD_SINGLE || required > MPI_THREAD_MULTIPLE) { | |||
| if (required != MPI_THREAD_SINGLE && required != MPI_THREAD_FUNNELED && | |||
| required != MPI_THREAD_SERIALIZED && required != MPI_THREAD_MULTIPLE) { | |||
There was a problem hiding this comment.
Just curious: what's the need for this? Doesn't MPI specify the relationship between all the MPI_THREAD_* values such that < SINGLE and > MULTIPLE is guaranteed to be invalid?
There was a problem hiding this comment.
In the new MPI ABI, values are still ordered but not consecutive, so users could use one of the invalid intermediate values.
https://github.com/mpi-forum/mpi-abi-stubs/blob/e89a80017a3fe9a05d903ced2564c6342d678165/mpi.h#L334
abouteiller
force-pushed
the
bugfix/env-thread-level-ignored
branch
from
b481893 to
1a0d2f7
Compare
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 1a0d2f7: review comments
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
`requested` in `MPI_Init_thread` would invoke the error handler, even though it is an useful override in some threaded library use cases. Signed-off-by: Aurelien Bouteiller <abouteil@amd.com>
abouteiller
force-pushed
the
bugfix/env-thread-level-ignored
branch
from
1a0d2f7 to
8ad7579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting OMPI_MPI_THREAD_LEVEL to a value different than
requestedinMPI_Init_threadwould invoke the error handler, even though it is an useful override in some threaded library use cases.