Miscellaneous improvements to DotNet / NuGet code #1482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @neubs-bsi |
sschuberth
force-pushed
the
dot-nu-get
branch
3 times, most recently
from
dd8b199 to
e62bb65
Compare
fviernau
previously approved these changes
Apr 26, 2019
fviernau
requested changes
Apr 26, 2019
Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
In particular, its parameter is a file, not a directory. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Because only the values, not the keys, are ever used. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Note that we cannot use our xmlMapper intended for writing / reading OrtResults here as it uses the wrong property naming strategy. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
For mapping attribute (not node) names, the JacksonXmlProperty instead of the JsonProperty annotation must be used. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
It does not really make sense to put class definitions into a static object. Move them to the class level, and also add a documentation link to each. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
fviernau
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.
This change is