Skip to content

Add table of contents support to ecosystem page #61595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add table of contents support to ecosystem page #61595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions web/pandas/community/ecosystem.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Ecosystem
[TOC]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[TOC]
[TOC]


Increasingly, packages are being built on top of pandas to address
specific needs in data preparation, analysis and visualization. This is
Expand Down
11 changes: 10 additions & 1 deletion web/pandas_web.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
from packaging import version
import requests
import yaml
from markdown.extensions.toc import TocExtension
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed if we follow the approach mentioned below


api_token = os.environ.get("GITHUB_TOKEN")
if api_token is not None:
Expand Down Expand Up @@ -487,7 +488,15 @@ def main(
)
else:
body = markdown.markdown(
content, extensions=context["main"]["markdown_extensions"]
content,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of repeating this here, we should probably add the ecosystem page to this condition above: if "pdeps/" in fname:

extensions= [
TocExtension(toc_depth="2-3", permalink=" #"),
"tables",
"fenced_code",
"meta",
"footnotes",
"codehilite",
]
)
# Apply Bootstrap's table formatting manually
# Python-Markdown doesn't let us config table attributes by hand
Expand Down
Loading