Allow getenv(null) for PHP > 8 #4007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
getenv
branch
3 times, most recently
from
29e4b96 to
c2c7c8b
Compare
ondrejmirtes
requested changes
May 22, 2025
tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
Outdated
Show resolved
Hide resolved
|
This pull request has been marked as ready for review. |
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
May 22, 2025
| if (PHP_VERSION_ID < 80000) { | ||
| yield __DIR__ . '/data/getenv-php74.php'; | ||
| } else { | ||
| yield __DIR__ . '/data/getenv-php80.php'; |
There was a problem hiding this comment.
This doesn't need to be in NodeScopeResolverTest. Move the files to nsrt/ and label them with proper // lint conditions.
There was a problem hiding this comment.
There is already similar conditions checks like above
if (PHP_VERSION_ID < 80000) {
yield __DIR__ . '/data/explode-php74.php';
} else {
yield __DIR__ . '/data/explode-php80.php';
}
The expectated type are different based on the PHP version, that's why I split the files.
The // lint condition is only used for the linter, not for the tests right ?
There was a problem hiding this comment.
Files in nsrt/ when testing type inference are filtered based on// lint as well.
There was a problem hiding this comment.
Oh ! Awesome !
ondrejmirtes
requested changes
May 22, 2025
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#13065