-
Notifications
You must be signed in to change notification settings - Fork 4
Refactor code for improved readability and maintainability. #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
priyanshu-kun
wants to merge
25
commits into
postman-open-technologies:develop
Choose a base branch
from
priyanshu-kun:main
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor code for improved readability and maintainability. #7
priyanshu-kun
wants to merge
25
commits into
postman-open-technologies:develop
from
priyanshu-kun:main
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e crawling process. Implement a crawling controller and create the Common Crawl driver.
…elay while fetching directories from cc server.
@priyanshu-kun Where is the Sails App that you had initialized? |
HimanshuS129
reviewed
Jul 6, 2023
… Common Crawl Server Using RabbitMQ NOTE: All code is contained within the downloadAndProcessIndexFilesInBackground() function.
…ing a bug in a consumer which is worker file.
…ing 'data' folder to 'dist' folder with runtime auto-creation. Implement feature to save final OpenAPI definitions in a text file instead of using global variables.
…definitions on a text file and start writing validate service
… refactoring of utility files
…ture/tests [Feature/tests] Introduce controller tests, implement validation service, and perform refactoring of utility files.
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
…iyanshu-kun/fix-cc-bug Fixed common crawl server bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is in response to the feedback and suggestions provided in pull request #5. The changes in this pull request aim to address the suggestions raised and further improve the codebase based on the feedback received.