Skip to content

Fix PHP 8.4 deprecation #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025
Merged

Conversation

cworreschk
Copy link
Contributor

When using PHP 8.4 the following deprecations warnings are displayed.

DEPRECATED  ProtoneMedia\LaravelVerifyNewEmail\MustVerifyNewEmail::newEmail(): Implicitly marking parameter $withMailable as nullable is deprecated, the explicit nullable type must be used instead in vendor/protonemedia/laravel-verify-new-email/src/MustVerifyNewEmail.php on line 20.

DEPRECATED  ProtoneMedia\LaravelVerifyNewEmail\MustVerifyNewEmail::sendPendingEmailVerificationMail(): Implicitly marking parameter $withMailable as nullable is deprecated, the explicit nullable type must be used instead in vendor/protonemedia/laravel-verify-new-email/src/MustVerifyNewEmail.php on line 87.

With using the explicit nullable type introduced in PHP 7.1, this is easy to fix without breaking anything else.

@cworreschk
Copy link
Contributor Author

My changes are not the reason for the failed checks, but your GitHub workflow 😉

@sairiz
Copy link

sairiz commented Mar 16, 2025

Hi @pascalbaljet

Can we get this merged please. Thanks for your awesome package!

@radimnemecek
Copy link

Hi @pascalbaljet
Just wanted to kindly follow up on this — the fix for the PHP 8.4 deprecation is small, backward-compatible, and would help avoid warnings in newer environments.

Would really appreciate it if you could take a moment to review and merge it when you get the chance. Thanks again for maintaining such a great package!

@pascalbaljet
Copy link
Contributor

Thanks! And sorry for the delay :)

@pascalbaljet pascalbaljet merged commit 530db50 into protonemedia:master Apr 1, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants