Update module to support apt-puppetcore.puppet.com #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for puppetcore* collections to the apt-based install task. When installing the puppetcore* collection, the task will download a release package from apt-puppetcore.puppet.com/public and add the credentials to /etc/apt/auth.conf.d/apt-puppetcore-puppet.conf. The other collections are unaffected. The `PUPPET_FORGE_TOKEN` environment variable must be set, which will be passed as the `password` to the task. Add debian 10-12 and ubuntu 18.04-24.04 to test installs in docker. By default, it will install 8.11.0 on Ubuntu noble. The tzdata package prompts for input, so use DEBIAN_FRONTEND=noninteractive when building the image.
Previously, apt-get install was reporting:
debconf: unable to initialize frontend: Dialog
debconf: (No usable dialog-like program is installed, so the dialog based frontend cannot be used. at /usr/share/perl5/Debconf/FrontEnd/Dialog.pm line 79, <STDIN> line 1.)
debconf: falling back to frontend: Readline
mhashizume
approved these changes
Mar 13, 2025
|
@kenyon @bastelfreak Have any thoughts/concerns about this? |
bastelfreak
approved these changes
Mar 13, 2025
kenyon
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #757 but for apt.
Updates the
puppet_agent::install_taskso it's possible to install deb-based packages from https://apt-puppetcore.puppet.com (debian and ubuntu). Credentials are required when installing from apt-puppetcore. The username defaults toforge-keyand the password must be set to your forge API token.Also updates the
puppet_agentclass so it's possible to manage agent versions over time:And it updates the Dockerfiles used to test install and upgrades. See docker/README.md for details.
I haven't changed the default behavior of the module if the collection is unspecified or is one of the existing puppet7, puppet7-nightly, puppet8, etc collections. If no collection is specified, then it continues to use the "unversioned" release package from
apt.puppet.com.