Update module to support puppetcore on Windows

[joshcooper]

This is analogous to #757 but for windows.

Updates the puppet_agent::install_task so it's possible to install msi-based packages from https://artifacts-puppetcore.puppet.com. Credentials are required when installing from puppetcore. The username defaults to forge-key and the password must be set to your forge API token.

When using WinRM, you must specify Windows credentials (using --user and --password arguments) to log into the host and puppetcore credentials to download the MSI (as username and password task parameters)

$ /opt/puppetlabs/bolt/bin/bolt task run puppet_agent::install \
  collection=puppetcore8 \
  version=8.11.0 \
  username=forge-key \
  password=... \
  --targets 'winrm://HOST' \
  --user Administrator \
  --password ...

Also updates the puppet_agent class so it's possible to manage agent versions over time:

class { 'puppet_agent':
  package_version => '8.11.0',
  collection => 'puppetcore8',
  password => Sensitive(...)
}

The puppet_agent::prepare::package class on Windows normally uses a file resource to download the MSI from the source. However, due to a bug in puppet, it is not possible to pass credentials as the userinfo component of the URL, e.g. https://forge-id:TOKEN@artifacts-puppetcore.puppet.com So instead use a powershell script to download the MSI. That code is borrowed from https://github.com/klab-systems/puppet_core_agent, credit to @klab-systems

[cthorn42]

Wanted to discuss the old 'puppet8-nightly' collection. With the new layout do we still require a different collection? Or can we get by with just always using puppetcore8, and then just adding logic to determine if we should set the dev parameter to true or false depending on the package version?
I think we already have ticketed the updating of https://github.com/puppetlabs/puppetlabs-puppet_agent/blob/14b1844f60a225387157c002c01c8c9d983c6fa2/acceptance/tests/test_upgrade_puppet7_to_puppet8.rb#L28C25-L28C40, and that is the only obvious usage of that puppet8-nightly collection.

[joshcooper]

Or can we get by with just always using puppetcore8, and then just adding logic to determine if we should set the dev parameter to true or false depending on the package version?

The dev parameter is mainly for PE CI, so that it can test agent upgrades to a version that's newer than what it ships with. It's not a direct replacement for puppetcore8-nightlies because the last passing agent SHA isn't always promoted to PE.

Beaker tests like test_upgrade_pouppet7_to_puppet8 run in our internal jenkins, so can already install from our internal nightly repos. I think d we're already overriding the yum_source, etc to point to artifactory. I'm not sure if we need to change the collection in the test? I can't access jenkins because of the lame Jenkins plugin/SAML bug, "You are now logged out of Jenkins, however this has not logged you out of SAML."

[bastelfreak]

why do you use getvar, instead of accessing the variable directly?

[joshcooper]

I was mainly following the getvar convention used in this module.

[bastelfreak]

why do you check if $puppet_agent::collection isn't undef? params.pp sets collection always, and the datatype in init.pp enforces String, so this shouldn't be required and the old syntax was fine?

[bastelfreak]

Edit: in the commit message you say:

If $puppet_agent::collection was undef, then the regex match would result in an error

But was is there a situation where undef is possible?

[bastelfreak]

Another question: Why a regex? Are there valid values like core8, core-latest? Could you maybe document them in the init.pp?

[joshcooper]

so this shouldn't be required and the old syntax was fine?

I removed the commit.

Why a regex? Are there valid values like core8, core-latest? Could you maybe document them in the init.pp?

They're documented in the task metadata:

Optional[Enum[puppet7, puppet8, puppet, puppet7-nightly, puppet8-nightly, puppet-nightly, puppetcore7, puppetcore8]]

But in puppet's init, it is defined to just be a String. I'll update the documentation for that parameter.