Skip to content

Deprecate parse_epw #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 4, 2025
Merged

Deprecate parse_epw #2467

merged 6 commits into from
Jun 4, 2025

Conversation

kandersolar
Copy link
Member

  • Towards Consider removing the parse_ iotools functions #2444
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@kandersolar kandersolar added this to the v0.12.1 milestone Jun 3, 2025
@kandersolar kandersolar added api io remote-data triggers --remote-data pytests labels Jun 3, 2025
@kandersolar kandersolar requested a review from AdamRJensen June 3, 2025 16:55
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kandersolar thanks for taking on this task!


return data, meta


def parse_epw(csvdata, coerce_year=None):
def _parse_epw(csvdata, coerce_year=None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again it seem preferable getting rid of the parse function all together (avoids duplicating the doc string).

@kandersolar kandersolar mentioned this pull request Jun 4, 2025
8 tasks
@AdamRJensen AdamRJensen merged commit 49528aa into pvlib:main Jun 4, 2025
29 of 30 checks passed
@kandersolar kandersolar deleted the parse_epw branch June 4, 2025 17:32
@kandersolar kandersolar modified the milestones: v0.12.1, v0.13.0 Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api io remote-data triggers --remote-data pytests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants