Restoring valgrind CI on smart_holder branch #3090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Using latest pytest main branch for 3.9 and 3.10. * WORKAROUND_ENABLING_ROLLBACK_OF_PR3068 in test_class_sh_trampoline_shared_from_this.py First experiment combining two potential fixes: latest pytest, workaround. If this succeeds the next step will be to try only latest pytest without the workaround. Note: the workaround is known to resolve the MSAN error reported under pybind#3068 (comment)
rwgk
force-pushed
the
sh_valgrind_on_again
branch
from
7215f7e to
d15aa8d
Compare
rwgk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback of PR Disabling valgrind for now. #3068.
Needs a
WORKAROUND_ENABLING_ROLLBACK_OF_PR3068in test_class_sh_trampoline_shared_from_this.pyUsing latest pytest main branch for 3.9 and 3.10. This update turned out NOT to make a difference for the valgrind issue but it is preserved anyway, in case it turns out that the root cause is in pytest (maybe not most likely but it is a possibility).
Note: the
WORKAROUND_ENABLING_ROLLBACK_OF_PR3068is known to also resolve the MSAN error reported under #3068 (comment)