-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[WIP] Preparation for v3.0.0 release: Upgrade guide & Changelog #5589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ff79927
to
ab3df83
Compare
…kip ci] [Browse prepv300/manuscript tree](https://github.com/rwgk/pybind11/tree/30b9c268aeb98308ea42aaccfd5fe454e173c6fc) [Browse prepv300/manuscript commits](https://github.com/rwgk/pybind11/commits/30b9c268aeb98308ea42aaccfd5fe454e173c6fc/)
We should highlight the CMake change, moving the default to FindPython will affect a lot, even with the back-compat tricks we used. For example, this will no longer work We can do the changelog in a separate PR if you prefer, that's mostly autogenerated so might be easier to split them up. |
I was actually hoping that we can collaborate here, working on the Upgrade guide and Changlog together. I'm mostly done with the Upgrade guide, except for two small-ish TODOs, to explain a couple traits structures. (I still need to add a couple matching tests.) It'd be awesome if you could make a first pass for the Changelog. Maybe some items from there should be added to the Upgrade guide, and maybe we don't have to mention #5580 in the Upgrade guide, only the Changelog? |
I'll try to do that soon. |
Reminder TODO (maybe mostly to self): I'd like to try the scikit-build-core conversion and convert the changelog to markdown before 3.0. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Which ones of these might we want to clean up for 3.0?
(Used ChatGPT to make that a table instead of a list) These are clearly unused:
|
…er_shared_ptr_with_smart_holder_support_enabled, move_only_holder_caster_unique_ptr_with_smart_holder_support_enabled in Upgrade guide.
…xtension compatibility. This isn't true, because we also modernized `PYBIND11_PLATFORM_ABI_ID` (which I believe was absolutely necessary). I think it'll be too complicated to explain that here, and there is a mention in the Upgrade guide.
@henryiii I'm done with a round of adding some new material ... ... and a few tiny fix-up commits: There is also #5603, adding a unit test to ensure that people can find a certain-to-work example after looking at the Upgrade guide. It'd be great to get that merged. Next I'll try to work through the PENDING CLEANUP listed in the PR description. |
I am starting to try out the current master branch (mainly to get access to
|
Just speaking for myself: I was thinking a week or so after we merge #5564. |
I'd also like to get #5598 in, I have a little to finish there. After that, I think we could make a beta or rc release, then maybe a week or so for full release? |
Description
PENDING:
Suggested changelog entry:
Browse prepv300/manuscript tree
Browse prepv300/manuscript commits