-
Notifications
You must be signed in to change notification settings - Fork 346
Attempt to make codecov less important #1203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
can you be specific about what it is you like about it? as far as i’m concerned this pr hasn’t touched anything in codecov that you didn’t have before. i am combining all the coverages into a single one and uploading that, the benefit here is that i can keep all the context data (which codecov throws away) and generate a html artifact. all of the existing functionality of codecov should remain in place ——
lol yes, the name of the pr is “ Attempt to make codecov less important” not “removes codecov” 😇 |
Having it apply flags for different runtimes et al. I was mostly pointing out that it's useful to have this combined thing as long as Codecov integration isn't compromised. |
FWIW, it's good to still upload separate reports from jobs because they get different flags/contexts assigned that are usable in the web UI, similar to the contexts that coveragepy can include. |
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
This is is the codecov report for this PR I see extra context on the right in main, but seems a bit useless. what am i missing? |
@webknjaz what am i missing from the codecov report, the summed up report vs individual ^ (see comment above) |
Depends on #1202
Related to #1201 -- had to close it due to CI not running
This all started because yesterday codecov was having issues, and p!$#ed me off...
This PR aims to reduce the emphasis on Codecov by adjusting coverage exclusions in pyproject.toml and modifying the CI workflow to handle coverage reporting differently.
Revise the CI workflow to use ubuntu-latest, update Tox versions, and introduce dedicated coverage reporting and artifact handling steps.Miscellaneous:
CI now runs on all branches -- instead of those that were pointing tomain
onlyUpdated tox version since python 3.8 is gone!