-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
gh-132737: Support profiling modules that import __main___ #132738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
@@ -0,0 +1 @@ | |||
Support profiling modules that import __main___, such as modules that use to pickle. The github issue has an example repro that throws an exception without this change, and succeeds with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support profiling modules that import __main___, such as modules that use to pickle. The github issue has an example repro that throws an exception without this change, and succeeds with it. | |
Support profiling modules that import ``__main__``, such as modules that use to pickle. The github issue has an example repro that throws an exception without this change, and succeeds with it. |
@@ -0,0 +1 @@ | |||
Support profiling modules that import __main___, such as modules that use to pickle. The github issue has an example repro that throws an exception without this change, and succeeds with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support profiling modules that import __main___, such as modules that use to pickle. The github issue has an example repro that throws an exception without this change, and succeeds with it. | |
Support profiling modules that import __main___, such as modules that use to pickle. |
NEWS does not need this
This is not going to work because you introduced extra function calls in cProfile record, which would confuse people. Try a simple I can work on this (kind of the responsible person for the module), or if you really want to take a swing at the issue I can give you some direction. |
I'd be happy to take a swing at it! Any pointers on what to look into? |
So Also, you need a regression test in this case. You need to write a test that fails with the original implementation, and passes after. Hopefully it won't be this complicated (I know it's not long, but I don't believe dataclass or even pickle is required to reproduce this issue). It's okay to use pickle if that's the easiest way. |
No description provided.