Migrate iOS app demo #6

nil-is-all · 2025-03-13T04:50:41Z

Reproduced https://github.com/pytorch/executorch/tree/main/examples/demo-apps/apple_ios/ExecuTorchDemo and added last line in docs to point to this GitHub repo

mergennachin · 2025-03-13T14:02:01Z

How is it different than this?

https://github.com/pytorch-labs/executorch-examples/blob/main/apple/ExecuTorchDemo/README.md

nil-is-all · 2025-03-13T19:58:37Z

The structure of https://github.com/pytorch-labs/executorch-examples/blob/main/apple/ExecuTorchDemo/README.md (let's call it ExecuTorchDemo README) is different from the original docs which are reflected in the PyTorch page. I followed the structure and comments of the original docs and the PyTorch page, which match.

E.g.: ExecuTorch README directly states to clone the ExecuTorch GitHub repo under Models and Labels section.
Whereas the PyTorch page, the original docs, and now the newly created README has a designated subsection stating "Getting Started Tutorial" under Prerequisites section.

Plus other comments like the first line welcoming the user as in the PyTorch demo docs page.
Finally, I have linked the execuTorch-examples GitHub repo, following this comment in this convo.

mergennachin · 2025-03-31T15:46:04Z

@nil-is-all any updates here since we last talked?

nil-is-all · 2025-03-31T16:49:45Z

Hi @mergennachin, I made the changes for the export script, and edited the "export model" section, and completed other changes such as adding instructions for swiftPM package and editing the directory paths. Seems PyTorch was deprecated for intel macbooks, so I am looking to test this out before pushing on GitHub.

mergennachin · 2025-04-02T18:24:06Z

Any updates @nil-is-all ?

We're not making this repo public until your change.

mergennachin · 2025-04-07T18:32:12Z

Any updates @nil-is-all ?

nil-is-all · 2025-04-07T22:42:48Z

@mergennachin sorry for the delay in response. I faced an issue while installing torch from source, posted it on #support channel in our Discord server too. Seems it is an open issue. I get the new mac tomorrow. While looking at ways to install, if it does not succeed, I will setup the mac and run local test tomorrow.

mergennachin · 2025-04-21T17:58:58Z

Any updates @nil-is-all ? We need to finalize this ASAP

Please use this directory

https://github.com/pytorch-labs/executorch-examples/tree/main/mv2

nil-is-all · 2025-04-21T18:06:10Z

Hey @mergennachin, been posting my current status on Discord. There is a current issue with the MPS Backend model which fails with a dim_order check. @digantdesai opened a new issue related to this.

I tried pushing the xcodeproj for the other two backend models by commenting out for MPS, but the current code expects all 3 backends, which @shoumikhin stated on discord. I'm awaiting his response on what changes to make to currently test just for the XNNPack and CoreML, as well as other comments I have posted in the #executorch-just-works Discord channel.

TL:DR - ready to locally test on xcode, all pre-requisites met and models exported other than MPS Backend.

nil-is-all · 2025-04-21T18:09:09Z

Also @mergennachin, are we not using MobileNetV3? Your comment here also reiterated using this structure for mv3

mergennachin · 2025-04-22T19:00:09Z

mv3/apple/ExecuTorchDemo/export.py

@@ -0,0 +1,48 @@
+#!/usr/bin/env python


move this file to mv3/python/export.py

mergennachin · 2025-04-22T19:01:13Z

mv3/apple/ExecuTorchDemo/README.md

+```bash
+import torch
+import torchvision.models as models
+from executorch.backends.apple.coreml.partition import CoreMLPartitioner
+from executorch.backends.apple.mps.partition import MPSPartitioner
+from executorch.exir.backend.backend_details import CompileSpec 
+from executorch.backends.xnnpack.partition.xnnpack_partitioner import XnnpackPartitioner
+from executorch.exir import to_edge_transform_and_lower
+import ssl
+import certifi
+
+
+def main() -> None:
+    model = models.mobilenet_v3_small(weights="DEFAULT").eval()
+    sample_inputs = (torch.randn(1, 3, 224, 224),)
+
+    et_program_coreml = to_edge_transform_and_lower(
+        torch.export.export(model, sample_inputs),
+        partitioner=[CoreMLPartitioner()],
+    ).to_executorch()
+
+    et_program_mps = to_edge_transform_and_lower(
+        torch.export.export(model, sample_inputs),
+        partitioner=[MPSPartitioner([CompileSpec("use_fp16", bytes([True]))])], 
+    ).to_executorch()
+
+    et_program_xnnpack = to_edge_transform_and_lower(
+        torch.export.export(model, sample_inputs),
+        partitioner=[XnnpackPartitioner()],
+    ).to_executorch()


no need to copy paste the whole code, just reference to the export.py file

shoumikhin · 2025-04-22T20:54:22Z

Are we moving the app or duplicating it?

nil-is-all · 2025-04-22T20:57:07Z

Are we moving the app or duplicating it?

The initial idea was to move from executorch/examples to here. The former directory has already been shifted to executorch-examples/apple/ExecuTorchDemo. Once this is up, executorch-examples/apple/ExecuTorchDemo can be removed.

mergennachin · 2025-04-23T14:39:47Z

@nil-is-all please don't duplicate. do the movement atomically.

do 'git mv' command so that it preserves history.

mergennachin

Do 'git mv' instead of copying.

nil-is-all · 2025-04-23T15:18:37Z

@nil-is-all please don't duplicate. do the movement atomically.
do 'git mv' command so that it preserves history.

@mergennachin just to confirm the final directory, do I git mv the current mv3/apple/ExecuTorchDemo directory to apple/ExecuTorchDemo created by Anthony?

author Nikhil Viswanath Sivakumar <68182521+nil-is-all@users.noreply.github.com> 1741841357 -0500 committer Nikhil Viswanath Sivakumar <nikhilviswanath@meta.com> 1745433893 -0500 Migrate iOS Demo App parent 5021c18 author Nikhil Viswanath Sivakumar <68182521+nil-is-all@users.noreply.github.com> 1741841357 -0500 committer Nikhil Viswanath Sivakumar <nikhilviswanath@meta.com> 1745433648 -0500 Migrate iOS Demo App Migrate iOS app demo as README.md Reproduced https://github.com/pytorch/executorch/tree/main/examples/demo-apps/apple_ios/ExecuTorchDemo and added last line in docs to point to this GitHub repo Changed file path to executorch-examples/mv3/apple/MobileNetV3Demo/README.md Changed directory and made changes after local testing Final directory: executorch-examples/mv3/apple/ExecuTorchDemo Changes from [current demo](https://pytorch.org/executorch/main/demo-apps-ios.html#): 1) Check Swift Package Manager version under Prerequisites 2) Export Model - export.py for backends 3) Directory changes in Final Steps Files for iOS MV3 Demo App export script for MV3.pte and XNNPack, CoreML, MPS backends Update README.md Rename mv3/apple/ExecuTorchDemo/export.py to mv3/apple/ExecuTorchDemo/python/export.py Removed export.py code block from README.md Added code formatting for Clone the Demo App subsection added snapshot url Delete mv3/apple/ExecuTorchDemo/ExecuTorchDemo/Resources/Models/MobileNet directory atomically migrated apple/ExecuTorch to mv3/apple/ExecuTorchDemo Updated directory structure to have python in mv3 folder fixed typo in .gitignore Update project.pbxproj to pin to 0.6.0 (#11) MV2 cpp and python example (#13) Update README.md (#12) * Update README.md * Update README.md fix directory and resolve conflicts MV2 cpp and python example (#13) Update .gitignore (#17)

nil-is-all requested review from shoumikhin and mergennachin March 13, 2025 04:50

nil-is-all self-assigned this Mar 13, 2025

facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 13, 2025

nil-is-all changed the title ~~Migrate iOS app demo as README.md~~ Migrate iOS app demo Apr 22, 2025

mergennachin reviewed Apr 22, 2025

View reviewed changes

mv3/apple/ExecuTorchDemo/export.py Outdated

@@ -0,0 +1,48 @@

#!/usr/bin/env python

Copy link

Contributor

mergennachin Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this file to mv3/python/export.py

mergennachin reviewed Apr 22, 2025

View reviewed changes

mergennachin requested changes Apr 23, 2025

View reviewed changes

nil-is-all mentioned this pull request Apr 23, 2025

Migrate demo apps to executorch-examples repository pytorch/executorch#10329

Closed

nil-is-all force-pushed the nil-is-all-patch-1 branch from a626921 to 139392c Compare April 23, 2025 18:50

nil-is-all force-pushed the nil-is-all-patch-1 branch from 139392c to a6d2321 Compare April 23, 2025 18:54

mergennachin approved these changes Apr 24, 2025

View reviewed changes

mergennachin added 2 commits April 24, 2025 10:57

Delete xcuserdata

6b8194b

Delete *.xcworkspace

8bea47b

mergennachin merged commit b0e909a into main Apr 24, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate iOS app demo #6

Migrate iOS app demo #6

nil-is-all commented Mar 13, 2025

mergennachin commented Mar 13, 2025

nil-is-all commented Mar 13, 2025

mergennachin commented Mar 31, 2025

nil-is-all commented Mar 31, 2025

mergennachin commented Apr 2, 2025

mergennachin commented Apr 7, 2025

nil-is-all commented Apr 7, 2025

mergennachin commented Apr 21, 2025

nil-is-all commented Apr 21, 2025 •

edited

Loading

nil-is-all commented Apr 21, 2025

mergennachin Apr 22, 2025

mergennachin Apr 22, 2025

shoumikhin commented Apr 22, 2025

nil-is-all commented Apr 22, 2025 •

edited

Loading

mergennachin commented Apr 23, 2025

mergennachin left a comment

nil-is-all commented Apr 23, 2025

Migrate iOS app demo #6

Migrate iOS app demo #6

Conversation

nil-is-all commented Mar 13, 2025

mergennachin commented Mar 13, 2025

nil-is-all commented Mar 13, 2025

mergennachin commented Mar 31, 2025

nil-is-all commented Mar 31, 2025

mergennachin commented Apr 2, 2025

mergennachin commented Apr 7, 2025

nil-is-all commented Apr 7, 2025

mergennachin commented Apr 21, 2025

nil-is-all commented Apr 21, 2025 • edited Loading

nil-is-all commented Apr 21, 2025

mergennachin Apr 22, 2025

Choose a reason for hiding this comment

mergennachin Apr 22, 2025

Choose a reason for hiding this comment

shoumikhin commented Apr 22, 2025

nil-is-all commented Apr 22, 2025 • edited Loading

mergennachin commented Apr 23, 2025

mergennachin left a comment

Choose a reason for hiding this comment

nil-is-all commented Apr 23, 2025

nil-is-all commented Apr 21, 2025 •

edited

Loading

nil-is-all commented Apr 22, 2025 •

edited

Loading