compare prepared vs. converted outputs for Embedding #2087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2087
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (7 Unrelated Failures)As of commit 1d6f7d4 with merge base 4805efd ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73266106 |
|
I have a fix here as well: #2085 |
navsud
pushed a commit
to navsud/ao
that referenced
this pull request
Apr 21, 2025
Summary: Fixed the embedding op and updated the test. Reviewed By: telgamal-1, jerryzh168 Differential Revision: D73266106
navsud
force-pushed
the
export-D73266106
branch
from
c791cf2 to
3f18cfb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73266106 |
navsud
added
the
topic: not user facing
Summary: Fixed the embedding op and updated the test. Reviewed By: telgamal-1, jerryzh168 Differential Revision: D73266106
navsud
force-pushed
the
export-D73266106
branch
from
3f18cfb to
1d6f7d4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73266106 |
jerryzh168
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fixed the embedding op and updated the test.
Reviewed By: telgamal-1, jerryzh168
Differential Revision: D73266106