[exir] Allow verifiers in _transform #10274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to allow users to transform an ExportedProgram using passes in places where it may result in a dialect that is not compliant with the original creation context. For example, if an ExportedProgram was created in an edge dialect and now needs to be run and transformed in a way that is not compliant with the EdgeDialectVerifier, such as in a delegate preprocess() function, then the user may want to override the verifier with their own or simply disable it. Differential Revision: [D73205727](https://our.internmc.facebook.com/intern/diff/D73205727/) [ghstack-poisoned]
digantdesai
requested review from
JacobSzwejbka,
tarun292 and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10274
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New Failures, 1 Cancelled Job, 6 Unrelated FailuresAs of commit a6cb006 with merge base 06f912d ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Apr 17, 2025
|
This pull request was exported from Phabricator. Differential Revision: D73205727 |
This is to allow users to transform an ExportedProgram using passes in places where it may result in a dialect that is not compliant with the original creation context. For example, if an ExportedProgram was created in an edge dialect and now needs to be run and transformed in a way that is not compliant with the EdgeDialectVerifier, such as in a delegate preprocess() function, then the user may want to override the verifier with their own or simply disable it. Differential Revision: [D73205727](https://our.internmc.facebook.com/intern/diff/D73205727/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D73205727 |
This is to allow users to transform an ExportedProgram using passes in places where it may result in a dialect that is not compliant with the original creation context. For example, if an ExportedProgram was created in an edge dialect and now needs to be run and transformed in a way that is not compliant with the EdgeDialectVerifier, such as in a delegate preprocess() function, then the user may want to override the verifier with their own or simply disable it. Differential Revision: [D73205727](https://our.internmc.facebook.com/intern/diff/D73205727/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D73205727 |
larryliu0820
approved these changes
Apr 18, 2025
This is to allow users to transform an ExportedProgram using passes in places where it may result in a dialect that is not compliant with the original creation context. For example, if an ExportedProgram was created in an edge dialect and now needs to be run and transformed in a way that is not compliant with the EdgeDialectVerifier, such as in a delegate preprocess() function, then the user may want to override the verifier with their own or simply disable it. Differential Revision: [D73205727](https://our.internmc.facebook.com/intern/diff/D73205727/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D73205727 |
This is to allow users to transform an ExportedProgram using passes in places where it may result in a dialect that is not compliant with the original creation context. For example, if an ExportedProgram was created in an edge dialect and now needs to be run and transformed in a way that is not compliant with the EdgeDialectVerifier, such as in a delegate preprocess() function, then the user may want to override the verifier with their own or simply disable it. Differential Revision: [D73205727](https://our.internmc.facebook.com/intern/diff/D73205727/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D73205727 |
facebook-github-bot
merged commit 66b1f8c
into
gh/digantdesai/34/base
75 of 86 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This is to allow users to transform an ExportedProgram using passes in places where it may result in a dialect that is not compliant with the original creation context.
For example, if an ExportedProgram was created in an edge dialect and now needs to be run and transformed in a way that is not compliant with the EdgeDialectVerifier, such as in a delegate preprocess() function, then the user may want to override the verifier with their own or simply disable it.
Differential Revision: D73205727