Skip to content

[mps] Disable dialect verifier under mps preprocess #10276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2025
Merged

[mps] Disable dialect verifier under mps preprocess #10276

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
518f0ed
[mps] Disable dialect verifier under mps preprocess
digantdesai Apr 17, 2025
f777c58
Update on "[mps] Disable dialect verifier under mps preprocess"
digantdesai Apr 18, 2025
6ba9773
Update on "[mps] Disable dialect verifier under mps preprocess"
digantdesai Apr 18, 2025
518d961
Update on "[mps] Disable dialect verifier under mps preprocess"
digantdesai Apr 18, 2025
0b805bd
Update on "[mps] Disable dialect verifier under mps preprocess"
digantdesai Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion backends/apple/mps/mps_preprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from typing import ClassVar, Dict, final, List, Tuple

import torch
from executorch import exir

from executorch.backends.apple.mps.operators.node_visitor import (
get_node_visitors,
Expand Down Expand Up @@ -35,6 +36,7 @@

from executorch.exir.passes.memory_format_ops_pass import DimOrderOpsRevertPass
from executorch.exir.program._program import _transform
from executorch.exir.verification.verifier import EXIREdgeDialectVerifier
from torch.export.exported_program import ExportedProgram

FORMAT = "[%(levelname)s %(asctime)s %(filename)s:%(lineno)s] %(message)s"
Expand Down Expand Up @@ -87,7 +89,19 @@ def preprocess(
# the `output_ids` array in the schema.

# TODO: Remove this once we have a better support for the dim-order ops.
edge_program = _transform(edge_program, DimOrderOpsRevertPass())
# Need to override the verifier to skip the non dim-order ops from tripping the default verifier.
edge_program = _transform(
edge_program,
DimOrderOpsRevertPass(),
override_verifiers=[
EXIREdgeDialectVerifier(
edge_compile_config=exir.EdgeCompileConfig(
_check_ir_validity=False, # Disable the edge dialect verifier, since we are in the mps backend.
),
class_only=True,
)
],
)

mps_graph = MPSGraph(
version="0",
Expand Down
Loading