Skip to content

[Executorch][llama] Hookup use_attention_mask option in the source transforms inside llm mananger #10286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2025

Conversation

…ansforms inside llm mananger

Differential Revision: [D73222734](https://our.internmc.facebook.com/intern/diff/D73222734/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Apr 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10286

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 258ea6f with merge base 06f912d (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kimishpatel added a commit that referenced this pull request Apr 17, 2025
…ansforms inside llm mananger

Differential Revision: [D73222734](https://our.internmc.facebook.com/intern/diff/D73222734/)

ghstack-source-id: 278833094
Pull Request resolved: #10286
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 17, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73222734

Copy link
Contributor

@lucylq lucylq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test to exercise this path?

@kimishpatel kimishpatel added the release notes: examples Changes to any of our example LLMs integrations, such as Llama3 and Llava label Apr 18, 2025
…e source transforms inside llm mananger"

Differential Revision: [D73222734](https://our.internmc.facebook.com/intern/diff/D73222734/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Apr 18, 2025
…ansforms inside llm mananger

Pull Request resolved: #10286

Differential Revision: [D73222734](https://our.internmc.facebook.com/intern/diff/D73222734/)
ghstack-source-id: 278952395
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73222734

…e source transforms inside llm mananger"

Differential Revision: [D73222734](https://our.internmc.facebook.com/intern/diff/D73222734/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Apr 18, 2025
…ansforms inside llm mananger

Pull Request resolved: #10286


ghstack-source-id: 278977226

Differential Revision: [D73222734](https://our.internmc.facebook.com/intern/diff/D73222734/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73222734

…e source transforms inside llm mananger"

Differential Revision: [D73222734](https://our.internmc.facebook.com/intern/diff/D73222734/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Apr 21, 2025
…ansforms inside llm mananger

Pull Request resolved: #10286


ghstack-source-id: 279292327

Differential Revision: [D73222734](https://our.internmc.facebook.com/intern/diff/D73222734/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73222734

@facebook-github-bot facebook-github-bot merged commit 8885421 into gh/kimishpatel/184/base Apr 21, 2025
159 of 165 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/kimishpatel/184/head branch April 21, 2025 23:08
kirklandsign pushed a commit that referenced this pull request Apr 21, 2025
…ansforms inside llm mananger

Pull Request resolved: #10286


ghstack-source-id: 279292327

Differential Revision: [D73222734](https://our.internmc.facebook.com/intern/diff/D73222734/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: examples Changes to any of our example LLMs integrations, such as Llama3 and Llava
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants