Skip to content

refactor no longer needed EXECUTORCH_BUILD_HOST_TARGETS #10320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2025

Conversation

bvanderhaar
Copy link
Contributor

@bvanderhaar bvanderhaar commented Apr 21, 2025

Summary

Removes EXECUTORCH_BUILD_HOST_TARGETS per @mergennachin comment. Fixes #9404

Test plan

Ensure executorch and cadence builds successfully:

./install_executorch.sh
mkdir cmake-out
cmake -DCMAKE_TOOLCHAIN_FILE=backends/cadence/cadence.cmake \
    -DCMAKE_INSTALL_PREFIX=cmake-out \
    -DCMAKE_BUILD_TYPE=Debug \
    -DPYTHON_EXECUTABLE=python3 \
    -DEXECUTORCH_BUILD_EXTENSION_RUNNER_UTIL=ON \
    -DEXECUTORCH_BUILD_HOST_TARGETS=ON \
    -DEXECUTORCH_BUILD_EXECUTOR_RUNNER=OFF \
    -DEXECUTORCH_BUILD_PTHREADPOOL=OFF \
    -DEXECUTORCH_BUILD_CPUINFO=OFF \
    -Bcmake-out .
cmake --build cmake-out -j8 --target install --config Debug
cmake -DCMAKE_BUILD_TYPE=Debug \
    -DCMAKE_TOOLCHAIN_FILE=examples/backends/cadence.cmake \
    -DCMAKE_PREFIX_PATH=cmake-out \
    -DMODEL_PATH=add.pte \
    -DNXP_SDK_ROOT_DIR=/home/user_name/nxp-sdk \
    -DNN_LIB_BASE_DIR=/home/user_name/nnlib-hifi4 \
    -Bcmake-out/examples/cadence \
    examples/cadence
cmake --build cmake-out/examples/cadence -j8 -t cadence_executorch_example
ls cmake-xt/*.bin
  • Test plan assumes nxp-sdk and nnlib-hifir are in user's home directory and Xtensa compiler is available (env vars set). See cadence docs
  • Since these are modifications to the build system, I leave it to discretion if CI builds provide enough risk protection to merge.
  • Happy to write tests if needed - I'll need a little direction here if needed. Remove usage of external flatc in builds and scripts #9306 ran ./install_executorch.sh, build_apple_frameworks.sh and build_android_library.sh.

Copy link

pytorch-bot bot commented Apr 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10320

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Pending

As of commit 9cd6685 with merge base 334af4a (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 21, 2025
@bvanderhaar
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

Copy link

pytorch-bot bot commented Apr 22, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@jathu
Copy link
Contributor

jathu commented Apr 22, 2025

LGTM so far. However, given the Cadence backend is the only place we are turning this on — can you include that in your test plan?

@bvanderhaar
Copy link
Contributor Author

LGTM so far. However, given the Cadence backend is the only place we are turning this on — can you include that in your test plan?

I updated the test plan - I'm waiting on Xtensa compiler to validate this locally. Appreciate the guidance.

Copy link

pytorch-bot bot commented Apr 24, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@jathu jathu merged commit 7783ade into pytorch:main Apr 24, 2025
168 of 173 checks passed
@jathu
Copy link
Contributor

jathu commented Apr 24, 2025

Thank you @bvanderhaar!

@shoumikhin
Copy link
Contributor

@bvanderhaar
Copy link
Contributor Author

@bvanderhaar please check if these CI failures are related https://hud.pytorch.org/pytorch/executorch/commit/7783adeb1b45ce928c2526381b46b0e0f0c77ee3

"error: Bundle identifier is missing" is the description of the error, googling suggests this is apple-specific. These changes are unlikely to be the cause. I didn't experience this error when testing.

jathu added a commit that referenced this pull request Apr 24, 2025
### Summary
Fixes an issue introduced in
#10320

### Test plan
CI

```
$ ./scripts/build_apple_frameworks.sh --Release --Debug --coreml --custom --mps --optimized --portable --quantized --xnnpack
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove EXECUTORCH_BUILD_HOST_TARGETS
5 participants