-
Notifications
You must be signed in to change notification settings - Fork 528
refactor no longer needed EXECUTORCH_BUILD_HOST_TARGETS #10320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10320
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 PendingAs of commit 9cd6685 with merge base 334af4a ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "topic: not user facing" |
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
LGTM so far. However, given the Cadence backend is the only place we are turning this on — can you include that in your test plan? |
I updated the test plan - I'm waiting on Xtensa compiler to validate this locally. Appreciate the guidance. |
…cadence build scripts
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
Thank you @bvanderhaar! |
@bvanderhaar please check if these CI failures are related |
"error: Bundle identifier is missing" is the description of the error, googling suggests this is apple-specific. These changes are unlikely to be the cause. I didn't experience this error when testing. |
### Summary Fixes an issue introduced in #10320 ### Test plan CI ``` $ ./scripts/build_apple_frameworks.sh --Release --Debug --coreml --custom --mps --optimized --portable --quantized --xnnpack ```
Summary
Removes EXECUTORCH_BUILD_HOST_TARGETS per @mergennachin comment. Fixes #9404
Test plan
Ensure executorch and cadence builds successfully:
./install_executorch.sh
,build_apple_frameworks.sh
andbuild_android_library.sh
.