Modified Dr. CI so it could detect runner disconnection failures #6542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ParamThakkar123 is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
clee2000
reviewed
Apr 18, 2025
| @@ -553,3 +564,16 @@ export async function isSameAuthor( | |||
| // * Cherry picking | |||
| return isSameEmail || isSameCommitUsername || isSamePrUsername; | |||
| } | |||
|
|
|||
| export function isRunnerDisconnectionFailure(job: RecentWorkflowsData): boolean { | |||
There was a problem hiding this comment.
I dont see this function actually called anywhere?
It would probably also be a better idea to do something similar as isInfraFlakyJob and add it to the flakyJobs list with the relevant info about runner disconnection so you don't have to make a new section
| export function isRunnerDisconnectionFailure(job: RecentWorkflowsData): boolean { | ||
| const runnerDisconnectionPatterns = [ | ||
| /The runner has received a shutdown signal/i, | ||
| /The operation was canceled/i, |
There was a problem hiding this comment.
Jobs can be cancelled for other reasons and I think it still ends up saying this
Suggested change
| /The operation was canceled/i, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pytorch/pytorch#66902