Skip to content

Remove get_frame_by_name test util #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 29, 2024
Merged

Remove get_frame_by_name test util #310

merged 3 commits into from
Oct 29, 2024

Conversation

NicolasHug
Copy link
Member

Closes #304

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 28, 2024
NicolasHug
NicolasHug commented Oct 28, 2024
View reviewed changes
test/resources/nasa_13013.mp4.stream3.frame000180.pt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are symlinks, so they're super cheap. I'll figure out in another PR whether we can just plainly rename/remove the existing "timexxx" frames.

@NicolasHug NicolasHug merged commit ae52b29 into pytorch:main Oct 29, 2024
40 checks passed
@NicolasHug NicolasHug deleted the frames_by_name branch October 29, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotts scotts scotts approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retire testing utils get_frame_by_name()
3 participants
@NicolasHug @scotts @facebook-github-bot