Skip to content

bit_rate -> bitRate for C++ code #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/torchcodec/_core/Encoder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ AudioEncoder::AudioEncoder(
const torch::Tensor wf,
int sampleRate,
std::string_view fileName,
std::optional<int64_t> bit_rate)
std::optional<int64_t> bitRate)
: wf_(wf) {
TORCH_CHECK(
wf_.dtype() == torch::kFloat32,
Expand Down Expand Up @@ -82,12 +82,12 @@ AudioEncoder::AudioEncoder(
TORCH_CHECK(avCodecContext != nullptr, "Couldn't allocate codec context.");
avCodecContext_.reset(avCodecContext);

if (bit_rate.has_value()) {
TORCH_CHECK(*bit_rate >= 0, "bit_rate=", *bit_rate, " must be >= 0.");
if (bitRate.has_value()) {
TORCH_CHECK(*bitRate >= 0, "bit_rate=", *bitRate, " must be >= 0.");
}
// bit_rate=None defaults to 0, which is what the FFmpeg CLI seems to use as
// well when "-b:a" isn't specified.
avCodecContext_->bit_rate = bit_rate.value_or(0);
avCodecContext_->bit_rate = bitRate.value_or(0);

validateSampleRate(*avCodec, sampleRate);
avCodecContext_->sample_rate = sampleRate;
Expand Down
2 changes: 1 addition & 1 deletion src/torchcodec/_core/Encoder.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class AudioEncoder {
// encoding will still work but audio will be distorted.
int sampleRate,
std::string_view fileName,
std::optional<int64_t> bit_rate = std::nullopt);
std::optional<int64_t> bitRate = std::nullopt);
void encode();

private:
Expand Down
Loading