Remove torchvision test dependency #648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
scotts
reviewed
Apr 22, 2025
| @@ -105,7 +105,7 @@ jobs: | |||
| run: ${CONDA_RUN} python -m pip install --upgrade pip | |||
| - name: Install PyTorch | |||
| run: | | |||
| ${CONDA_RUN} python -m pip install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu${{ env.cuda_version_without_periods }} | |||
| ${CONDA_RUN} python -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cu${{ env.cuda_version_without_periods }} | |||
There was a problem hiding this comment.
Looks like we still need torchvision here because of the GPU benchmarks.
There was a problem hiding this comment.
aaaaah I forgot we run those. We probably... shouldn't, since we never check 🤷
There was a problem hiding this comment.
I think there's some value in doing it, as it makes sure that the GPU benchmarks don't become stale. That is, it's not about the actual performance result from the benchmark, it's more a check that it's still usable. There may also be value in doing that on the CPU side as well.
|
Current CI failures look like the pre-existing problem, so this should improve things. |
scotts
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we shouldn't need torchvision since #612