Skip to content

Avoid shadowing local variables #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

Avoid shadowing local variables #688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/torchcodec/_core/SingleStreamDecoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,15 +630,15 @@ FrameBatchOutput SingleStreamDecoder::getFramesInRange(
FrameOutput SingleStreamDecoder::getFramePlayedAt(double seconds) {
validateActiveStream(AVMEDIA_TYPE_VIDEO);
StreamInfo& streamInfo = streamInfos_[activeStreamIndex_];
double frameStartTime =
double lastDecodedStartTime =
ptsToSeconds(streamInfo.lastDecodedAvFramePts, streamInfo.timeBase);
double frameEndTime = ptsToSeconds(
double lastDecodedEndTime = ptsToSeconds(
streamInfo.lastDecodedAvFramePts + streamInfo.lastDecodedAvFrameDuration,
streamInfo.timeBase);
if (seconds >= frameStartTime && seconds < frameEndTime) {
if (seconds >= lastDecodedStartTime && seconds < lastDecodedEndTime) {
// We are in the same frame as the one we just returned. However, since we
// don't cache it locally, we have to rewind back.
seconds = frameStartTime;
seconds = lastDecodedStartTime;
}

setCursorPtsInSeconds(seconds);
Expand Down
Loading