Skip to content

docs: remove import.meta.glob for faster docs and less bugs #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 26, 2025

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented May 23, 2025

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests
  • Other

Why is it needed?

It's a little less optimized DX wise but more resilient. The big problem with it now is that qwik wants to preload all the meta glob imports on every route and that takes >100s. Therefore SPA navigation can never be instant. I'd like to have instant SPA navigation on qwik UI even on slow 3G. The DX without it is not that bad actually, it's basically 10s work with cursor.

(Playwright tests are passing similarly to before)

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have add necessary docs (if needed)
  • Added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented May 23, 2025

⚠️ No Changeset found

Latest commit: ef2bc66

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented May 23, 2025

Open in StackBlitz

npm i https://pkg.pr.new/qwikifiers/qwik-ui@1076
npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@1076
npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/styled@1076
npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/utils@1076

commit: ef2bc66

@maiieul maiieul moved this from Backlog to In Review in Qwik UI Development May 25, 2025
@maiieul maiieul merged commit f75773c into qwikifiers:main May 26, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in Qwik UI Development May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants