make zonal open stacks of length < 32 #950
Conversation
not sure if we want this size or not but that's easy to configure
|
Probably needs some form of test as well? If creating a stack with 800 layers and saving it to NC makes sense I can do that |
|
Hmm I'm going to change how open works pretty soon (non closure version), so we can open more like 300 Yes nc it's just one object so the number of layers doesn't matter as much. But let's wait and do it properly. We also need to fix the type stability of multy layer stacks, the scaling isn't good currently |
|
Well some code like this will be needed anyway right? Or do we actually want to change the way this works, and "chunk" the files into groups that we open one at a time? Horrific I know, but if it's for that sweet sweet performance.... |
|
I will try and just write it properly soon. Maybe we can merge this as a stopgap but not worth doing anything complicated. Have you tried it with 32 layers already? How is the compile time? |
|
Haven't tried with 32 layers but IIRC that's the recommended limit for static arrays, so I figure it's probably fine here too |
|
Different problem here... It's 32 deep closures! |
|
Ah yeah it would do that...in that case the limit is 5 ish I believe |
not sure if we want this size or not but that's easy to configure