Update to latest vscode-json-languageservice #1072
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary motivation for doing this is to allow warnings to be reported on schemas. I would like to report warnings on schemas as a part of redhat-developer#1065. When updating the json language service, there were many API changes that I needed to adapt to, and some tests that I changed. Notably, I needed to copy a lot of the implementation of `JSONSchemaService` into our subclass of `JSONSchemaService`. `JSONSchemaService` turns all schema identifiers into URIs and escapes all `/` in the fragment, and does this in the private `normalizeId` method that we can't override Combined, these behaviours cause many tests to fail. Closes redhat-developer#1069 Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates vscode-json-languageservice to the latest version.
The primary motivation for doing this is to allow warnings to be reported on schemas. I would like to report warnings on schemas as a part of #1065.
When updating the json language service, there were many API changes that I needed to adapt to, and some tests that I changed.
Notably, I needed to copy a lot of the implementation of
JSONSchemaServiceinto our subclass ofJSONSchemaService.JSONSchemaServiceturns all schema identifiers into URIs and escapes all/in the fragment, and does this in the privatenormalizeIdmethod that we can't override Combined, these behaviours cause many tests to fail.What issues does this PR fix or reference?
Closes #1069
Is it tested? How?
Existing test suite.