Run pipeline in current thread if all the keys on same node

[xrayw]

fix #4148

[ggivo]

LGTM
I think we should also add dedicated tests to verify MultiNodePipeline with single command to a node and MultiNodePipeline multiple commands to the same node are processed successfully

[xrayw]

@ggivo May i check should i add the test to ClusterPipeliningTest class?

[ggivo]

@ggivo May i check should i add the test to ClusterPipeliningTest class?

Yes, I would suggest adding them there.

[xrayw]

@ggivo I add a test, can you help me to check it. cause i don't have the cluster environment. thank you very much

[ggivo]

@ggivo I add a test, can you help me to check it. cause i don't have the cluster environment. thank you very much

@xrayw
Hey, thanks for working on it! If you have Docker, you should be able to bootstrap a test environment locally using
make start-test-env
This will also include the Redis Cluster used by other tests.

details can be found in contribution guideline

[xrayw]

@ggivo test passed now, if the test code is correct.
i can't run make start-test-env on Colima ( MacOS ), So i test it by make test.

[ggivo]

@xrayw
Thanks again, will take a final look and provide an update.

@ggivo test passed now, if the test code is correct. i can't run make start-test-env on Colima ( MacOS ), So i test it by make test.

make test will do in this case but we are planning to replace it with the Dockerised environment at some point and rely only on containers. I am on Sonoma ( MacOS ), and it works for me. Curious what is the error you are getting so we can try to address it.

[xrayw]

Error response from daemon: invalid reference format
Started test environment with Redis version 8.0.

Although it says it is started, but, actually there is no redis-server started.

[ggivo]

LGTM