refactor: use react-server-dom-vite

[hi-ogawa]

Hi redwood team!

As I've discussed on Discord, I'm planning to propose react-server-dom-vite soon and I wanted to make sure it would work for redwood sdk, so I'm testing it on this PR. The package is built from my folk https://github.com/hi-ogawa/react/tree/feat-rsc-vite and tgz is pushed to hi-ogawa/vite-plugins#768.

API-wise this simply replaces hard-coded __webpack_require__ with setPreloadModule, so I'm expecting that there's no hassle migrating this, but I'd appreciate if you can take a look at the change and whether new API works for you. Also any feedback is very welcome (either here or feel free to ping on discord as well). Thank you!

[peterp]

Amazing!!!

…

On Sat, Apr 26, 2025, 11:00 Hiroshi Ogawa ***@***.***> wrote: Hi redwood team! As I've discussed on Discord, I'm planning to propose react-server-dom-vite soon and I wanted to make sure it would work for redwood sdk, so I'm testing it on this PR. The package is built from my folk https://github.com/hi-ogawa/react/tree/feat-rsc-vite and tgz is pushed to hi-ogawa/vite-plugins#768 <hi-ogawa/vite-plugins#768>. API-wise this simply replaces hard-coded __webpack_require__ with setPreloadModule, so I'm expecting that there's no hassle migrating this, but I'd appreciate if you can take a look at the change and whether new API works for you. Also any feedback is very welcome (either here or feel free to ping on discord as well). Thank you! ------------------------------ You can view, comment on, or merge this pull request online at: #360 Commit Summary - 4ac70fb <4ac70fb> chore(deps): add react-server-dom-vite - 0e9b453 <0e9b453> wip: use setPreloadModule File Changes (12 files <https://github.com/redwoodjs/sdk/pull/360/files>) - *M* package.json <https://github.com/redwoodjs/sdk/pull/360/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519> (7) - *M* pnpm-lock.yaml <https://github.com/redwoodjs/sdk/pull/360/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bb> (647) - *M* sdk/src/runtime/client.tsx <https://github.com/redwoodjs/sdk/pull/360/files#diff-1013664d9733e0294b7e29f496664d0c0848283624db85e31ce49f4537952b12> (8) - *M* sdk/src/runtime/register/worker.ts <https://github.com/redwoodjs/sdk/pull/360/files#diff-02c931b1abf77c2348ccb68b7415eef82bca961eb105a35133afc0e30448c514> (2) - *M* sdk/src/runtime/render/renderToRscStream.ts <https://github.com/redwoodjs/sdk/pull/360/files#diff-656f21614accbb3f0708b522fc9ecbe6deb3385a22f089a6884ea2d98fbdea7a> (2) - *M* sdk/src/runtime/worker.tsx <https://github.com/redwoodjs/sdk/pull/360/files#diff-2dada149ec3b9a271d5235f269cdf93cae916c3cbc3f033e92c2af0ded76dcbe> (10) - *M* sdk/types/react.d.ts <https://github.com/redwoodjs/sdk/pull/360/files#diff-3264d7d9a82951908a496a3c4da69a0cb45584122540ddf817b2b57f7df1c4e0> (24) - *M* starters/minimal/package.json <https://github.com/redwoodjs/sdk/pull/360/files#diff-b1c834997a7e4ad734a336b0a8f5917504bcdc6b0612a69f61099795b4c2418c> (4) - *M* starters/minimal/src/app/pages/Home.tsx <https://github.com/redwoodjs/sdk/pull/360/files#diff-c29eeb72b14e53f59c079c56de12af0b94bec981f0a205cf6ab5a7d3cec87251> (2) - *A* starters/minimal/src/app/pages/client.tsx <https://github.com/redwoodjs/sdk/pull/360/files#diff-73e9b0e302f8b101181cd93863f0d2b4e968e84368cc7cac14c2b0f32440e7eb> (8) - *M* starters/minimal/worker-configuration.d.ts <https://github.com/redwoodjs/sdk/pull/360/files#diff-0afa43e0757f3fc9086f02c221fb38d6c1e3e1a0282c2bc46bc3917b96237c59> (3) - *M* starters/standard/package.json <https://github.com/redwoodjs/sdk/pull/360/files#diff-814ac52c41553e35b592d99bb645ce91083a4b1c5c518f4e0a36bdb8cdee0d54> (2) Patch Links: - https://github.com/redwoodjs/sdk/pull/360.patch - https://github.com/redwoodjs/sdk/pull/360.diff — Reply to this email directly, view it on GitHub <#360>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAK6MK5CVBUKCV3O3PQL4L23NDMXAVCNFSM6AAAAAB35GBUT2VHI2DSMVQWIX3LMV43ASLTON2WKOZTGAZDCNRTHA2TIOI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[justinvdm]

Thank you so much for this @hi-ogawa! And for keeping us in mind 🙇 Using vite-specific implementation for RSC would be first prize for us, so we're keen to get this to work.

I'll take a look at this PR this week coming. I might also make some changes to get a feel for the API and understand the changes better. Does that all work for you?

[hi-ogawa]

@justinvdm Yes, please feel free to dig in and make changes 🙏 For now I just commented them out, but probably more code can be removed. I'm also checking with Waku and I might still need to keep "bundler config" API though. I'll share it on discord if there's an update.

[justinvdm]

Hi @hi-ogawa, I've tested it out on a few examples of ours in dev and production, and it is working great!

Here's one example deployed with this change: https://kitchensink.redwoodjs.workers.dev/

From API perspective, also great - no more __webpack_require global, or hoop jumping for creating manifest maps.

I've gone ahead and updated the codebase in this PR to expect react-server-dom-vite. We'll just wait out for the packages to be released and ready, and we'll update the PR to the relevant canary builds and merge!

Thank you again 🙏