Fixes reload and refresh not setting loading to false after completing #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394
The problem was that the equality in AsyncState wasn't being done properly when going from AsyncDataReloading to AsyncData because as a side effect to the reloading state being a subclass of AsyncData. I've added the equality with the 3 loading states. I think that would be the correct solution for the exhaustiveness.
Additionally, while creating a test, I've noticed that a future signal .reload() wasn't propagating the reload future because the internal Completer wasn't being recreated.
For this, would it be ok to remove the batch? I've added it because it is how it's written in
setValue, but I'm not sure it's needed.