Import tags #165
Merged
Import tags #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hernanvicente
force-pushed
the
102_import_tags
branch
from
620c2ae to
9d592e1
Compare
- Added import_tags method to handle tag imports from tags.csv - Added import_topic_tags method to handle topic tag associations from topic_tags.csv - Preserved original tag IDs from tags.csv during import
hernanvicente
force-pushed
the
102_import_tags
branch
from
56cbe46 to
43c4a01
Compare
hernanvicente
force-pushed
the
102_import_tags
branch
from
43c4a01 to
3bf4ce7
Compare
hernanvicente
approved these changes
May 23, 2025
hernanvicente
approved these changes
May 23, 2025
There was a problem hiding this comment.
Thanks for working on this @Gabe-Torres, I did push a commit with some necessary changes 👍. Here my comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Issue Does This PR Cover, If Any?
Resolves #120
Tags are correctly imported with their original IDs
Tag names are preserved
Topic tag associations are being created correctly for topics that exist
Found 3 topics in
topic_tags.csvthat don't exist intopics_obfuscated.csvTopic ID 1, Topic ID 5818, Topic ID 5819. The
import_topic_tagmethod handles this by only creating associations for topics that existSomething to note -
The CSV is not ordered by ID. But when we look at the first 5 tags in the database, we see sequential IDs, though the data is correct, I think.
There are 10 extra tags in the database vs CSV, which is interesting. Maybe the destroy method isn't working as it should. Is it possible this is because of seeds? It doesn't seem to affect the import process.