Mods to support spectra file IO out of fortran #34
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,9 @@ endif() | |
| project( SpecUtils VERSION 2025.1.0 ) | ||
| enable_testing() # Enable here to allow running `ctest` from top-most build dir | ||
|
|
||
| # Add this line to specify the architectures for MacOS | ||
| set(CMAKE_OSX_ARCHITECTURES "x86_64;arm64" CACHE STRING "Build architectures for MacOS" FORCE) | ||
|
There was a problem hiding this comment. @wcjohns so everything builds ok but macos*. Copilot said to add this but that didn't help. There was a problem hiding this comment. there's
There was a problem hiding this comment. We can probably remove that added line; I think the macOS architectures are set by the nanobind stuff. I just triggered a build on the main branch, and it ran fine. Below is the step that is installing stuff into the python package:
And the actual error: |
||
|
|
||
| option( SpecUtils_ENABLE_D3_CHART "Enables exporting of the D3 chart format" ON ) | ||
| option( SpecUtils_D3_SUPPORT_FILE_STATIC "Compiles the JS and CSS files into memory, rather than reading files on disk; disable to allow changing JS/CSS without having to recompile" ON ) | ||
| option( SpecUtils_ENABLE_URI_SPECTRA "Enables encoding/decoding spectra to URIs (for, ex, QR-codes) - requires linking to zlib" OFF ) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
SpecUtils_FLT_PARSE_METHODis left as 'default_value' here, there is some logic below to hopefully pick the most reasonable float parsing method. Like for MSVC ≥2019, it should pick 'FromChars'.Is there is reason to default to the slowest common denominator, or was it giving you an issue?