-
Notifications
You must be signed in to change notification settings - Fork 86
Improvement/zenko 4838 sur api #2214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement/zenko 4838 sur api #2214
Conversation
Hello williamlardier,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
a86bf4c
to
5ded516
Compare
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
5ded516
to
6220fc1
Compare
This looks like a good candidate for a new branch? We already use Zenko 2.11 for Artesca 3.1. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
8dd0acc
to
11ee836
Compare
I added a commit because now we are rejecting calls to GetAccountInfos without any filter provided. This affects one test. I might update this commit if the changes are not enough, but the SUR part won't be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of feels we are fighting against cucumber here: to introduce some test fixture, we reduce the "descriptiveness" of the tests, and thus the benefit of cucumber...
LGTM otherwise, but we need to settle on the destination branch.
11ee836
to
a2b5fca
Compare
- Share the same logic as the quota initialization - Improve the policy attachment step to be more configurable from the feature files - Test that SUR API is exposed, authv4 works for both Roles and Users, and ensure authz is working as well. The actual check on the metrics is flexible, as this is already tested in SUR repository. Issue: ZENKO-4838
- Required to build scubaclient Issue: ZENKO-4838
- Added support for location in the MetricsClass Issue: ZENKO-4838
Issue: ZENKO-4838
Issue: ZENKO-4838
a2b5fca
to
b0ad327
Compare
Adding SUR API backend (exposed) to Zenko. CTST tests are added.