Skip to content

Improvement/zenko 4838 sur api #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

williamlardier
Copy link
Contributor

Adding SUR API backend (exposed) to Zenko. CTST tests are added.

@bert-e
Copy link
Contributor

bert-e commented Apr 22, 2025

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Apr 22, 2025

Incorrect fix version

The Fix Version/s in issue ZENKO-4838 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.11.5

Please check the Fix Version/s of ZENKO-4838, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Apr 23, 2025

Incorrect fix version

The Fix Version/s in issue ZENKO-4838 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.11.6

Please check the Fix Version/s of ZENKO-4838, or the target
branch of this pull request.

@williamlardier williamlardier force-pushed the improvement/ZENKO-4838-sur-api branch from a86bf4c to 5ded516 Compare April 28, 2025 10:31
@bert-e
Copy link
Contributor

bert-e commented Apr 28, 2025

Incorrect fix version

The Fix Version/s in issue ZENKO-4838 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.11.7

Please check the Fix Version/s of ZENKO-4838, or the target
branch of this pull request.

@williamlardier williamlardier force-pushed the improvement/ZENKO-4838-sur-api branch from 5ded516 to 6220fc1 Compare April 28, 2025 10:43
@williamlardier williamlardier marked this pull request as ready for review April 28, 2025 12:29
@williamlardier williamlardier requested review from benzekrimaha and francoisferrand and removed request for benzekrimaha April 28, 2025 12:41
@williamlardier
Copy link
Contributor Author

This looks like a good candidate for a new branch? We already use Zenko 2.11 for Artesca 3.1.

@bert-e
Copy link
Contributor

bert-e commented Apr 28, 2025

Incorrect fix version

The Fix Version/s in issue ZENKO-4838 contains:

  • 2.11.6

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.11.7

Please check the Fix Version/s of ZENKO-4838, or the target
branch of this pull request.

@williamlardier williamlardier force-pushed the improvement/ZENKO-4838-sur-api branch 2 times, most recently from 8dd0acc to 11ee836 Compare April 28, 2025 13:04
@williamlardier
Copy link
Contributor Author

I added a commit because now we are rejecting calls to GetAccountInfos without any filter provided. This affects one test. I might update this commit if the changes are not enough, but the SUR part won't be updated.

Copy link
Contributor

@francoisferrand francoisferrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of feels we are fighting against cucumber here: to introduce some test fixture, we reduce the "descriptiveness" of the tests, and thus the benefit of cucumber...

LGTM otherwise, but we need to settle on the destination branch.

@williamlardier williamlardier force-pushed the improvement/ZENKO-4838-sur-api branch from 11ee836 to a2b5fca Compare April 30, 2025 07:05
- Share the same logic as the quota initialization
- Improve the policy attachment step to be more configurable from
  the feature files
- Test that SUR API is exposed, authv4 works for both Roles and
  Users, and ensure authz is working as well. The actual check
  on the metrics is flexible, as this is already tested in SUR
  repository.

Issue: ZENKO-4838
- Required to build scubaclient

Issue: ZENKO-4838
@williamlardier williamlardier force-pushed the improvement/ZENKO-4838-sur-api branch from a2b5fca to b0ad327 Compare May 5, 2025 09:30
@williamlardier williamlardier changed the base branch from development/2.11 to improvement/ZENKO-5000 May 5, 2025 09:31
@williamlardier williamlardier changed the base branch from improvement/ZENKO-5000 to development/2.12 May 5, 2025 09:34
@scality scality deleted a comment from bert-e May 5, 2025
@williamlardier williamlardier changed the base branch from development/2.12 to w/2.12/improvement/ZENKO-5000 May 5, 2025 09:41
@scality scality deleted a comment from bert-e May 5, 2025
@scality scality deleted a comment from bert-e May 5, 2025
@bert-e bert-e deleted the branch w/2.12/improvement/ZENKO-5000 May 7, 2025 09:40
@bert-e bert-e closed this May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants