Skip to content

chore(e2e): introduce user login case and git integrations page tests #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

hamir-suspect
Copy link
Contributor

πŸ“ Description

Allows for running tests from local dev env.
Adds test case module that starts the session from a logged in user
Ads UI tests for git integrations page

βœ… Checklist

  • I have tested this change
  • This change requires documentation update

@lucaspin
Copy link
Collaborator

@hamir-suspect I don't see a successful CI run for these new tests. Am I missing something?

@hamir-suspect hamir-suspect force-pushed the has/e2e/ui-onboarding branch from 6503f78 to 66647c2 Compare April 17, 2025 09:00
@hamir-suspect
Copy link
Contributor Author

@lucaspin the e2e tests have to be run manually as a promotion, do you think we should have automatic promotions when there is a change in e2e path?

@lucaspin
Copy link
Collaborator

@hamir-suspect that would be nice, but I don't think you have to do that as part of this PR

Copy link
Collaborator

@lucaspin lucaspin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved before because I forgot about my other comment about the use of CSS classes in the wallaby tests πŸ˜…

@hamir-suspect hamir-suspect requested a review from lucaspin April 18, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants