-
Notifications
You must be signed in to change notification settings - Fork 1
Add build script for macOS & fix some cli/readme issues #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ORT build fails without it
Seeing this issue: microsoft/onnxruntime#22679 with the previous commit
for venv and static libs
damn... ORT v1.16.3 fails on linux |
Thanks for making ort-builder in the first place. I feel like I would have definitely used it for Demucs if it were possible (rather than rewriting the universe). Thanks for the PR! I can't test the OSX parts but as long as the other parts continue working for me, I'm fine with it. |
Other than the STFT/ISTFT part (which i've seen you have in C++ already) do you see another reason why demucs couldn't run on onnxruntime? It would be interesting for your project to see if it worked via the onnxruntime webgpu execution provider |
I do believe it was the STFT/iSTFT. It's an interesting project idea. I feel like I'd have to:
I'll note it down for a future curiosity. |
@olilarkin I got a (to be made public soon) version of demucs for onnx, like you said - take out the stft/istft code from the Now I'm running into serious trouble understanding webgpu, webnn, jsep, etc. for onnxruntime Building for webgpu says to use Then, when I compile my actual C++ code, when do I supply |
That's great news. Yeah the bin2c stuff only works for small models unfortunately. I haven't compiled ORT for wasm with wgpu, webnn support etc. I am not sure if you have to pass the emscripten flag -s USE_WEBGPU=1, i think that will be done for onnxruntime by the onnxruntime cmake/build scripts if necessary. https://onnxruntime.ai/docs/build/web.html this seems relevant...
|
Check it out: https://github.com/sevagh/demucs.onnx |
Great to see you using ort-builder for this!
Here is some work to get it building on macOS. Will need to check that the linux and wasm builds are not affected by the changes