Fix #6544: Properly format nested type names in extensions #6769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szihs
force-pushed
the
haaggarwal/fix-6544-declref-extn
branch
3 times, most recently
from
01f572b to
8f85ffd
Compare
kaizhangNV
previously approved these changes
Apr 11, 2025
|
Is there an issue number associated with this? |
This would require update of pypi |
csyonghe
reviewed
Apr 14, 2025
csyonghe
previously requested changes
Apr 14, 2025
Modify DeclRefBase::toText to properly handle types defined in extensions by qualifying them with their parent type name. This ensures getFullName() returns the full name like 'FullPrecisionOptimizer<half>.State' instead of just '.State'. Also handle other nested types in structs/classes similarly.
- stopping namespace inclusion for extension members - Update to use getTargetType() to handle the generic arguments - update test cases
szihs
force-pushed
the
haaggarwal/fix-6544-declref-extn
branch
from
8f85ffd to
3093c2a
Compare
csyonghe
reviewed
Apr 16, 2025
expipiplus1
approved these changes
Apr 23, 2025
szihs
added a commit
to szihs/slang
that referenced
this pull request
May 7, 2025
shader-slang#6769) * Fix shader-slang#6544: Properly format nested type names in extensions Modify DeclRefBase::toText to properly handle types defined in extensions by qualifying them with their parent type name. This ensures getFullName() returns the full name like 'FullPrecisionOptimizer<half>.State' instead of just '.State'. Also handle other nested types in structs/classes similarly. * Update extension reflection handling - with generics args and namespaces - stopping namespace inclusion for extension members - Update to use getTargetType() to handle the generic arguments - update test cases * Simplify code to remove using parentDecl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify DeclRefBase::toText to properly handle types defined in extensions by qualifying them with their parent type name. This ensures getFullName() returns the full name like 'FullPrecisionOptimizer.State' instead of just '.State'.
Also add diagnostic tests for the same