-
Notifications
You must be signed in to change notification settings - Fork 4
New Design #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leonard84
wants to merge
29
commits into
master
Choose a base branch
from
new-design-vite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New Design #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR, titled "New Design", introduces several new configurations and files to support the site's new design, testing, and deployment pipeline.
- Added Vite configuration with Tailwind CSS support
- Included a visual snapshot test using Playwright
- Created and updated GitHub Actions workflows for build verification, screenshot updates, and deployment
Reviewed Changes
Copilot reviewed 13 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
spock-website/vite.config.ts | Configures Vite with Tailwind CSS support |
spock-website/tests/visual.spec.ts | Adds a visual snapshot test using Playwright |
spock-website/src/main.ts | Sets up the main entry point by importing stylesheet and icons |
spock-website/src/icons.ts | Initializes FontAwesome icons in the library |
spock-website/playwright.config.ts | Configures Playwright testing for multiple browsers |
.github/workflows/verify.yaml | Implements a workflow to verify PR builds and run tests |
.github/workflows/update-reference-screenshots.yaml | Updates screenshots via Playwright and commits changes if necessary |
.github/workflows/deploy.yaml | Deploys the static website to GitHub Pages |
Files not reviewed (7)
- .gitattributes: Language not supported
- compositor.json: Language not supported
- spock-website/index.html: Language not supported
- spock-website/package.json: Language not supported
- spock-website/src/style.css: Language not supported
- spock-website/tsconfig.json: Language not supported
- spock-website/tsconfig.test.json: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.