Skip to content

Fix typos in chat client module #3013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typos in chat client module #3013

wants to merge 1 commit into from

Conversation

jamespud
Copy link

@jamespud jamespud commented May 6, 2025

fix typos in chat client module.

thanks.

@jamespud jamespud force-pushed the fix-typo-chat-client branch from 8286cee to 841ebe1 Compare May 6, 2025 12:47
dev-jonghoonpark
dev-jonghoonpark reviewed May 6, 2025
View reviewed changes
spring-ai-client-chat/src/main/java/org/springframework/ai/chat/client/DefaultChatClient.java Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 709 also contains ChatClient2Builder. Please revise it as well.

spring-ai-client-chat/src/main/java/org/springframework/ai/chat/package-info.java
* In line with Domain-Driven Design principles, this package includes implementations of
* entities and value objects specific to the chat context, such as ChatPrompt and
* ChatResponse, adhering to the ubiquitous language of chat interactions in AI models.
*
* <p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend a closing tag?

Copy link
Author

@jamespud jamespud May 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming it should be split. Or should I use <br>?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the <p> tag needed to be closed, but it seems that's not necessary.
I apologize for the confusion.

@jamespud jamespud force-pushed the fix-typo-chat-client branch from 841ebe1 to 95a268a Compare May 6, 2025 13:16
Fix typos in chat client module
0b99a7c 
Signed-off-by: Wenli Tian <jamespud9@gmail.com>
@jamespud jamespud force-pushed the fix-typo-chat-client branch from 95a268a to 0b99a7c Compare May 6, 2025 14:05
@jamespud
Copy link
Author

jamespud commented May 7, 2025

@dev-jonghoonpark I did some changes yesterday, is that ok?

@dev-jonghoonpark
Copy link
Contributor

I think it looks good.

However, I am just one of the contributors.
So unfortunately, I don't have the authority to approve it.
Please wait for the maintainer to review it.

@jamespud

@jamespud
Copy link
Author

jamespud commented May 7, 2025

I think it looks good.

However, I am just one of the contributors. So unfortunately, I don't have the authority to approve it. Please wait for the maintainer to review it.

@jamespud

Understood, thanks for noticing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dev-jonghoonpark dev-jonghoonpark dev-jonghoonpark left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamespud @dev-jonghoonpark