-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add observability to Bedrock Titan Embedding model #3014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PSriVarshan
wants to merge
7
commits into
spring-projects:main
Choose a base branch
from
PSriVarshan:add-observability-to-bedrock-titan
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add observability to Bedrock Titan Embedding model #3014
PSriVarshan
wants to merge
7
commits into
spring-projects:main
from
PSriVarshan:add-observability-to-bedrock-titan
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ff770f
to
95ba402
Compare
Thanks. A few things to clean up in the PR.
adding
and changing the bean def to be
Also, you can use |
0cd6a52
to
ed41e60
Compare
Signed-off-by: PSriVarshan <psvvarshan@gmail.com>
Signed-off-by: PSriVarshan <psvvarshan@gmail.com>
Signed-off-by: PSriVarshan <psvvarshan@gmail.com>
Signed-off-by: PSriVarshan <psvvarshan@gmail.com>
Signed-off-by: PSriVarshan <psvvarshan@gmail.com>
Signed-off-by: PSriVarshan <psvvarshan@gmail.com>
ed41e60
to
b127661
Compare
I think now the branch is fully ready and optimal. Thanks a ton for the guidance @markpollack. Waiting for your further guidance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces observability to the Bedrock Titan Embedding Model by adding Micrometer
Observation
around the embedding API call. This ensures consistent metrics and tracing support in accordance with the Spring AI observability pattern.ObservationRegistry
.model
,input_type
, andinput_length
.Changes
BedrockTitanEmbeddingModel.java
to wrap the API call inObservation.createNotStarted().observe(...)
Related Issue
Fixes #2983
Checklist
ObservationRegistry
Do let me know if there are any further modifications required within the PR