-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Polish OpenTelemetryResourceAttributes #44677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update OpenTelemetryResourceAttributes to use StringUtils.uriDecode(...) as it provides the same functionality as the custom decode(...) method. Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
Update OpenTelemetryResourceAttributes to use StringUtils.uriDecode(...) as it provides the same functionality as the custom decode(...) method. See gh-44677 Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
Thanks @nosan ! |
I just found this core issue: spring-projects/spring-framework#34570. It actually does alter a Unicode character. Consider the following test: @Test
void otelResourceAttributes() {
this.environmentVariables.put("OTEL_RESOURCE_ATTRIBUTES", "key8=%20ś\u2019");
assertThat(getAttributes()).containsEntry("key8", " ś’");
} The custom
|
Hm. We should then stay on the custom decode method until this is fixed. I'll get that fixed. |
Thanks, sorry for inconvenience :( |
No problem. I've fixed that in 3bd75f6 and subscribed to spring-projects/spring-framework#34570. When that's fixed in Framework, we can use their decode method. |
Update
OpenTelemetryResourceAttributes
to useStringUtils.uriDecode(...)
, as it provides the same functionality as the customdecode(...)
method.