Consolidate filter handling: applyFilters. #32655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
I don't think this improves the code. |
bclozel
added
status: declined
I apologize. I won't submit PRs for stylistic changes or personal issues in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates the functionality of the previous methods, enableFilters and disableFilters, which were performing similar tasks, thus eliminating redundancy.
The new applyFilters method integrates these two operations into one, enhancing code reusability and reducing duplication. This change makes the code more concise and easier to maintain. Additionally, the new method accepts an enable parameter to determine whether to enable or disable the filters, allowing both actions to be handled within a single method.